Ticket #21 (closed defect: fixed)

Opened 9 years ago

Last modified 7 years ago

Events can have start times not aligned to the nearest minute

Reported by: bmcguffin Owned by: sdanthin
Priority: Medium Milestone: ScriptBuilder 1
Component: ScriptBuilder GUI Version: 1.0
Severity: Minor Keywords:
Cc:

Description

If an event has a start time with the value NN:NN:XX, where N is any number and X is any number other than zero, the event icon will show up in the incident editor frame at the nearest minute, but clicking on that icon will not do anything. The event effectively becomes unreachable.

I believe this is because the script model supports events timed down to the second, but the GUI elements were only designed for events timed down to the minute.

To recreate:

Create a new incident, or open an existing one.
Click on any event to bring up its event editor window. Note that the start time in the bottom left corner ends in ":00."
Change the start time to end in ":01,: i.e. make the event start 1 second later.
Note that the event disappears from the current editor frame. This is desired behavior; the frame should only display events which occur at the current time.
Close the event editor frame.
Note that the icon for that event still appears on the timeline.
Click on the icon again. Note that clicking on it now does nothing; no event editor window appears.
The event still exists; if the incident is saved to an XML file and opened, the altered event will still appear. It just can't be further altered in the GUI, because it's out of reach.

Suggested change:

A simple fix would be to cause events to snap to the nearest minute whenever they're moved. A better long-term fix (in my opinion) would be to change the GUI to support to-the-second event start times.

Change History

comment:1 Changed 9 years ago by bmcguffin

  • Status changed from new to accepted

comment:2 Changed 9 years ago by bmcguffin

  • Status changed from accepted to closed
  • Resolution set to fixed

Took the easy way out on this one. Added a statement at the beginning of ScriptIncident?.addNewEvent() which rounds the intended start time to the nearest minute. The long-term fix is still an option; no code was removed. Removing the rounding statement I added will allow to-the-second start times again, in case the long-term fix is later enacted.

Last edited 9 years ago by bmcguffin (previous) (diff)

comment:3 Changed 9 years ago by bmcguffin

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:4 Changed 8 years ago by jdalbey

  • Component changed from none to ScriptBuilder GUI
  • Milestone set to ScriptBuilder 1

comment:5 Changed 7 years ago by jdalbey

  • Owner changed from bmcguffin to sdanthin
  • Status changed from reopened to assigned

comment:6 Changed 7 years ago by sdanthin

Change event resolution to every 10s and make sure icons do not overlap. Selecting should still be possible, and hover time should display the correct time. No changes should be made to the underlying data model, but time setting field in the editor window should restrict input to every 10 seconds.

comment:7 Changed 7 years ago by sdanthin

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.