Changeset 9 in tmcsimulator-scriptbuilder for trunk

Timestamp:

07/25/2017 02:59:09 PM (9 years ago)

Author:

bmcguffin

Message:

Decoupled ScriptIncident? from the observer-observable pattern. SimulationScript? no longer implements Observer; instead, ScriptIncident? calls methods in SimulationScript? which notify the script's observers of a change.

Also: TimeSlice? now contains a stub method, toXML(), which returns the contents of the timeslice in XML text format.

Location:

trunk/src/scriptbuilder/structures

Files:

• ScriptIncident.java (modified) (9 diffs)
• SimulationScript.java (modified) (3 diffs)
• TimeSlice.java (modified) (1 diff)

trunk/src/scriptbuilder/structures/ScriptIncident.java

@@ -19 +19 @@
  * @version 2017/06/29
  */
-public class ScriptIncident extends Observable
+public class ScriptIncident
 {
 
@@ -66 +66 @@
      */
     private int latestStart = 0;
+
+    SimulationScript script;
 
     /**
@@ -82 +84 @@
         this.name = name;
         this.description = description;
-        this.addObserver(script);
+        this.script = script;
         slices = new TreeMap<Integer, TimeSlice>();
     }
@@ -102 +104 @@
         this.name = name;
         this.description = description;
-        this.addObserver(script);
+        this.script = script;
         slices = new TreeMap<Integer, TimeSlice>();
     }
@@ -124 +126 @@
         this.name = name;
         this.description = description;
-        this.addObserver(script);
+        this.script = script;
         slices = new TreeMap<Integer, TimeSlice>();
         this.setOffset(offset);
@@ -137 +139 @@
     {
         this.collapsed = collapsed;
-        setChanged();
-        notifyObservers();
+        script.update();
     }
 
@@ -150 +151 @@
     {
         this.offset = offset;
-        setChanged();
-        notifyObservers();
+        script.update();
     }
 
@@ -253 +253 @@
         if (this.slices.get(i) != null)
         {
-            setChanged();
-            notifyObservers(new SliceChangedEvent(this.slices.get(i)));
+            script.broadcastEvent(new SliceChangedEvent(this.slices.get(i)));
         }
     }
@@ -277 +276 @@
     public void setIncidentActive()
     {
-        setChanged();
-        notifyObservers(new IncidentFocusedEvent(this));
+        script.broadcastEvent(new IncidentFocusedEvent(this));
     }
 

trunk/src/scriptbuilder/structures/SimulationScript.java

@@ -26 +26 @@
  * @version 2017/06/22
  */
-public class SimulationScript extends Observable implements Observer
+public class SimulationScript extends Observable
 {
 
@@ -155 +155 @@
 
     /**
-     * Pass incident focus events on to observers, if applicable.
-     *
-     * @param o The observable object sending the update
-     * @param arg Argument parameter of update
-     */
-    @Override
-    public void update(Observable o, Object arg)
-    {
-        if (arg instanceof SliceChangedEvent)
-        {
-            // The slice focus has changed; pass the message
-            setChanged();
-            notifyObservers(arg);
-        }
-        else if (arg instanceof IncidentFocusedEvent)
-        {
-            // The slice focus has changed; pass the message
-            setChanged();
-            notifyObservers(arg);
-        }
-        else
-        {
-            // The script has changed, notify observers
-            setChanged();
-            notifyObservers(this);
-        }
+     * Update the script's observers.
+     *
+     */
+    public void update()
+    {
+        // The script has changed, notify observers
+        setChanged();
+        notifyObservers(this);
+    }
+
+    /**
+     * Tell this script's observers that there is a new slice event.
+     *
+     * @param e the slice focus event
+     */
+    public void broadcastEvent(SliceChangedEvent e)
+    {
+        // The slice focus has changed; pass the message
+        setChanged();
+        notifyObservers(e);
+    }
+
+    /**
+     * Tell this script's observers that there is a new slice event.
+     *
+     * @param e the incident focus event
+     */
+    public void broadcastEvent(IncidentFocusedEvent e)
+    {
+        // The slice focus has changed; pass the message
+        setChanged();
+        notifyObservers(e);
     }
 
@@ -210 +216 @@
             ex.printStackTrace();
         }
-        update(this, this);
+        this.update();
     }
 }

trunk/src/scriptbuilder/structures/TimeSlice.java

@@ -185 +185 @@
 
     }
+
+    /**
+     * Stub method. Converts the contents of this timeslice to a correctly
+     * formatted <ScriptEvent> XML element.
+     *
+     * @return XML conversion of this timeslice.
+     */
+    public String toXML()
+    {
+        return "STUB";
+    }
 }